make tests slightly easier to write

This commit is contained in:
Aneurin Barker Snook
2023-10-07 10:44:47 +01:00
parent 923734fe25
commit 1a3c213dc1
3 changed files with 20 additions and 20 deletions
+5 -5
View File
@@ -13,15 +13,15 @@ func TestEmail(t *testing.T) {
{Input: "testexample.com", Err: true},
}
for _, testCase := range testCases {
err := Email(testCase.Input)
if testCase.Err {
for _, tc := range testCases {
err := Email(tc.Input)
if tc.Err {
if err == nil {
t.Errorf("Expected %q to be an invalid email; got nil", testCase.Input)
t.Errorf("Expected %q to be an invalid email; got nil", tc.Input)
}
} else {
if err != nil {
t.Errorf("Expected %q to be a valid email; got %s", testCase.Input, err)
t.Errorf("Expected %q to be a valid email; got %s", tc.Input, err)
}
}
}
+10 -10
View File
@@ -16,12 +16,12 @@ func TestMaxLength(t *testing.T) {
{L: 8, Input: "abcdefghi", Err: true},
}
for _, testCase := range testCases {
t.Logf("Max length %d for %q", testCase.L, testCase.Input)
for _, tc := range testCases {
t.Logf("Max length %d for %q", tc.L, tc.Input)
f := MaxLength(testCase.L)
err := f(testCase.Input)
if testCase.Err {
f := MaxLength(tc.L)
err := f(tc.Input)
if tc.Err {
if err == nil {
t.Error("Expected an error; got nil")
}
@@ -47,12 +47,12 @@ func TestMinLength(t *testing.T) {
{L: 8, Input: "abcdefghi"},
}
for _, testCase := range testCases {
t.Logf("Min length %d for %q", testCase.L, testCase.Input)
for _, tc := range testCases {
t.Logf("Min length %d for %q", tc.L, tc.Input)
f := MinLength(testCase.L)
err := f(testCase.Input)
if testCase.Err {
f := MinLength(tc.L)
err := f(tc.Input)
if tc.Err {
if err == nil {
t.Error("Expected an error; got nil")
}
+5 -5
View File
@@ -18,15 +18,15 @@ func TestUUID(t *testing.T) {
{Input: "01234567-89ab-cdef-ghij-klmnopqrstuv", Err: true},
}
for _, testCase := range testCases {
err := UUID(testCase.Input)
if testCase.Err {
for _, tc := range testCases {
err := UUID(tc.Input)
if tc.Err {
if err == nil {
t.Errorf("Expected %q to be an invalid UUID; got nil", testCase.Input)
t.Errorf("Expected %q to be an invalid UUID; got nil", tc.Input)
}
} else {
if err != nil {
t.Errorf("Expected %q to be a valid UUID; got %s", testCase.Input, err)
t.Errorf("Expected %q to be a valid UUID; got %s", tc.Input, err)
}
}
}