Files
project-manager/tests/ApiTestCase.php
T
aneurinandClaude Sonnet 5 c82bdbbf0e Passwordless-only auth: drop registration and passwords entirely
There is now one way in: POST /api/auth/magic-link with an email address. It
creates the account (unverified) if the address is new -- that's the only
"sign up" -- and emails a sign-in link either way, subject to the existing
60s-per-user resend throttle. Opening the link (POST /api/auth/verify-email,
unchanged) is what actually creates the session, and marks the address
verified the first time. Since a session can now only ever come from an
opened link, "authenticated" implies "verified" -- there's no more
authenticated-but-unverified state, so the resend-verification endpoint and
all the "verify your email" nagging UI are gone too.

Backend
- migrations/008: ALTER TABLE users DROP COLUMN password_hash.
- UserRepository: create() takes only an email; new findOrCreateByEmail()
  (race-safe) backs the magic-link endpoint.
- AuthController: register()/login() removed; requestLoginLink() now
  find-or-creates before sending.
- EmailVerificationController: resend() removed (dead -- you can't be
  authenticated and unverified); requestChange() drops the password check,
  now just { email }.
- EmailVerifier: sendVerification() removed (unused once register() and
  resend() are gone); sendLoginLink() is the one email people get.
- Routes: POST /auth/register, POST /auth/login, POST /email/verification
  all gone.

Frontend
- LoginView: email field + "Send sign-in link" button, nothing else.
  RegisterView and the /register route are gone.
- auth store: register()/login()/resendVerification() removed;
  requestEmailChange() drops the password param.
- ProfileView: password field and the "verify your email" section removed,
  leaving just the change-email form.
- App.vue: the "verify email" header badge is gone; DashboardView's
  unverified-address notice is gone.
- Now-dead .badge/.badge--warn/a.badge CSS removed.

Tests: AuthTest and EmailVerificationTest rewritten for the new flow (52
tests total, down from 58 -- consolidated, not reduced coverage).
ApiTestCase::authHeader() signs in via the real magic-link -> verify flow.

Verified end-to-end against the rebuilt container and the dev server: a brand
new address gets an account + session from one link; /auth/register,
/auth/login and /email/verification all 404; the UI shows no password field
anywhere and no verification nagging. Also fixed the README's "Try it" curl
snippets, which had been silently broken since JSON_PRETTY_PRINT was added
(grep patterns didn't tolerate the space after ':').

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-04 14:47:46 +01:00

171 lines
5.1 KiB
PHP

<?php
declare(strict_types=1);
namespace Tests;
use PDO;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\ResponseInterface;
use Slim\App;
use Slim\Psr7\Factory\ServerRequestFactory;
/**
* Boots the real Slim app against a throwaway SQLite database with all
* migrations applied. Email goes to a per-test log file (MAIL_TRANSPORT=log).
*/
abstract class ApiTestCase extends TestCase
{
protected App $app;
private string $databasePath;
private string $mailLogPath;
private ?PDO $db = null;
/** @var array<string, string> */
private array $env = [];
protected function setUp(): void
{
$unique = uniqid('todo-test-', true);
$this->databasePath = sys_get_temp_dir() . "/{$unique}.sqlite";
$this->mailLogPath = sys_get_temp_dir() . "/{$unique}.mail.log";
$this->setEnv([
'DATABASE_PATH' => $this->databasePath,
'APP_URL' => 'https://app.test',
'MAIL_TRANSPORT' => 'log',
'MAIL_LOG_PATH' => $this->mailLogPath,
]);
$pdo = $this->db();
$pdo->exec('PRAGMA foreign_keys = ON');
foreach (glob(dirname(__DIR__) . '/migrations/*.sql') ?: [] as $migration) {
$pdo->exec((string) file_get_contents($migration));
}
$this->app = require dirname(__DIR__) . '/src/bootstrap.php';
}
protected function tearDown(): void
{
$this->db = null;
@unlink($this->databasePath);
@unlink($this->mailLogPath);
foreach (array_keys($this->env) as $key) {
putenv($key);
unset($_ENV[$key], $_SERVER[$key]);
}
$this->env = [];
}
/** @param array<string, string> $vars */
private function setEnv(array $vars): void
{
foreach ($vars as $key => $value) {
putenv("{$key}={$value}");
$_ENV[$key] = $value;
$_SERVER[$key] = $value;
$this->env[$key] = $value;
}
}
/** A connection to the test database, for seeding rows directly. */
protected function db(): PDO
{
if ($this->db === null) {
$this->db = new PDO('sqlite:' . $this->databasePath, null, null, [
PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_ASSOC,
]);
}
return $this->db;
}
/**
* @param array<string, mixed>|null $body
* @param array<string, string> $headers
*/
protected function request(
string $method,
string $path,
?array $body = null,
array $headers = [],
): ResponseInterface {
$request = (new ServerRequestFactory())->createServerRequest($method, $path);
foreach ($headers as $name => $value) {
$request = $request->withHeader($name, $value);
}
if ($body !== null) {
$request = $request->withParsedBody($body)->withHeader('Content-Type', 'application/json');
}
return $this->app->handle($request);
}
/**
* Sign in (creating the account if needed) via the real magic-link flow and
* return an `Authorization` header for the resulting session.
*
* @return array<string, string>
*/
protected function authHeader(string $email = 'user@example.com'): array
{
// Clear any resend throttle so this works even if the address was just
// emailed a link earlier in the same test.
$this->db()->prepare('UPDATE users SET verification_email_sent_at = NULL WHERE email = :email')
->execute(['email' => $email]);
$this->request('POST', '/api/auth/magic-link', ['email' => $email]);
$token = $this->decode(
$this->request('POST', '/api/auth/verify-email', ['token' => $this->tokenFromEmail()]),
)['token'];
return ['Authorization' => 'Bearer ' . $token];
}
/** All emails sent so far, oldest first. @return list<array{to: string, subject: string, body: string}> */
protected function sentEmails(): array
{
if (!is_file($this->mailLogPath)) {
return [];
}
$lines = array_filter(explode("\n", (string) file_get_contents($this->mailLogPath)));
return array_map(
static fn (string $line): array => json_decode($line, true, 512, JSON_THROW_ON_ERROR),
array_values($lines),
);
}
/** @return array{to: string, subject: string, body: string} */
protected function lastEmail(): array
{
$emails = $this->sentEmails();
self::assertNotEmpty($emails, 'Expected an email to have been sent.');
return $emails[array_key_last($emails)];
}
/** Pull the magic-link token out of an email body. */
protected function tokenFromEmail(?array $email = null): string
{
$email ??= $this->lastEmail();
self::assertSame(1, preg_match('/verify-email\?token=([a-f0-9]+)/', $email['body'], $m));
return $m[1];
}
/**
* @return array<string, mixed>
*/
protected function decode(ResponseInterface $response): array
{
return (array) json_decode((string) $response->getBody(), true, 512, JSON_THROW_ON_ERROR);
}
}