Files
aneurinandClaude Sonnet 5 7da881bb78 Add a config toggle to turn off new user registration
APP_ALLOW_REGISTRATION (default true) gates the only "sign up" this app has --
the account-creation side effect of POST /api/auth/magic-link. When false, an
unknown address is silently ignored (find-only, no findOrCreateByEmail) while
an existing address still gets its sign-in link as normal; the response is
identical either way (202, same message), so there's still no enumeration
signal.

- Config::allowRegistration, read from APP_ALLOW_REGISTRATION.
- AuthController::requestLoginLink takes the flag; only looks up (doesn't
  create) when it's off.
- docker-compose.yml / .env.example / README document the new var.
- ApiTestCase::reconfigure() rebuilds the app against changed env (same
  database) for tests that need a non-default Config; two new AuthTest
  cases cover both halves (blocks a new address, doesn't block an existing
  one). 59 tests pass.

Verified against the rebuilt container: with the flag on (default), a new
address gets a link and an account; switched off via the same env var, a
brand-new address gets the same 202 but no email and no user row, while an
address that already had an account still receives its link.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-04 18:19:48 +01:00

183 lines
5.5 KiB
PHP

<?php
declare(strict_types=1);
namespace Tests;
use PDO;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\ResponseInterface;
use Slim\App;
use Slim\Psr7\Factory\ServerRequestFactory;
/**
* Boots the real Slim app against a throwaway SQLite database with all
* migrations applied. Email goes to a per-test log file (MAIL_TRANSPORT=log).
*/
abstract class ApiTestCase extends TestCase
{
protected App $app;
private string $databasePath;
private string $mailLogPath;
private ?PDO $db = null;
/** @var array<string, string> */
private array $env = [];
protected function setUp(): void
{
$unique = uniqid('todo-test-', true);
$this->databasePath = sys_get_temp_dir() . "/{$unique}.sqlite";
$this->mailLogPath = sys_get_temp_dir() . "/{$unique}.mail.log";
$this->setEnv([
'DATABASE_PATH' => $this->databasePath,
'APP_URL' => 'https://app.test',
'MAIL_TRANSPORT' => 'log',
'MAIL_LOG_PATH' => $this->mailLogPath,
]);
$pdo = $this->db();
$pdo->exec('PRAGMA foreign_keys = ON');
foreach (glob(dirname(__DIR__) . '/migrations/*.sql') ?: [] as $migration) {
$pdo->exec((string) file_get_contents($migration));
}
$this->app = require dirname(__DIR__) . '/src/bootstrap.php';
}
protected function tearDown(): void
{
$this->db = null;
@unlink($this->databasePath);
@unlink($this->mailLogPath);
foreach (array_keys($this->env) as $key) {
putenv($key);
unset($_ENV[$key], $_SERVER[$key]);
}
$this->env = [];
}
/** @param array<string, string> $vars */
private function setEnv(array $vars): void
{
foreach ($vars as $key => $value) {
putenv("{$key}={$value}");
$_ENV[$key] = $value;
$_SERVER[$key] = $value;
$this->env[$key] = $value;
}
}
/**
* Change config env vars and rebuild the app against them (same database).
* For settings Config::load() only reads once at boot, e.g. APP_ALLOW_REGISTRATION.
*
* @param array<string, string> $vars
*/
protected function reconfigure(array $vars): void
{
$this->setEnv($vars);
$this->app = require dirname(__DIR__) . '/src/bootstrap.php';
}
/** A connection to the test database, for seeding rows directly. */
protected function db(): PDO
{
if ($this->db === null) {
$this->db = new PDO('sqlite:' . $this->databasePath, null, null, [
PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_ASSOC,
]);
}
return $this->db;
}
/**
* @param array<string, mixed>|null $body
* @param array<string, string> $headers
*/
protected function request(
string $method,
string $path,
?array $body = null,
array $headers = [],
): ResponseInterface {
$request = (new ServerRequestFactory())->createServerRequest($method, $path);
foreach ($headers as $name => $value) {
$request = $request->withHeader($name, $value);
}
if ($body !== null) {
$request = $request->withParsedBody($body)->withHeader('Content-Type', 'application/json');
}
return $this->app->handle($request);
}
/**
* Sign in (creating the account if needed) via the real magic-link flow and
* return an `Authorization` header for the resulting session.
*
* @return array<string, string>
*/
protected function authHeader(string $email = 'user@example.com'): array
{
// Clear any resend throttle so this works even if the address was just
// emailed a link earlier in the same test.
$this->db()->prepare('UPDATE users SET verification_email_sent_at = NULL WHERE email = :email')
->execute(['email' => $email]);
$this->request('POST', '/api/auth/magic-link', ['email' => $email]);
$token = $this->decode(
$this->request('POST', '/api/auth/verify-email', ['token' => $this->tokenFromEmail()]),
)['token'];
return ['Authorization' => 'Bearer ' . $token];
}
/** All emails sent so far, oldest first. @return list<array{to: string, subject: string, body: string}> */
protected function sentEmails(): array
{
if (!is_file($this->mailLogPath)) {
return [];
}
$lines = array_filter(explode("\n", (string) file_get_contents($this->mailLogPath)));
return array_map(
static fn (string $line): array => json_decode($line, true, 512, JSON_THROW_ON_ERROR),
array_values($lines),
);
}
/** @return array{to: string, subject: string, body: string} */
protected function lastEmail(): array
{
$emails = $this->sentEmails();
self::assertNotEmpty($emails, 'Expected an email to have been sent.');
return $emails[array_key_last($emails)];
}
/** Pull the magic-link token out of an email body. */
protected function tokenFromEmail(?array $email = null): string
{
$email ??= $this->lastEmail();
self::assertSame(1, preg_match('/verify-email\?token=([a-f0-9]+)/', $email['body'], $m));
return $m[1];
}
/**
* @return array<string, mixed>
*/
protected function decode(ResponseInterface $response): array
{
return (array) json_decode((string) $response->getBody(), true, 512, JSON_THROW_ON_ERROR);
}
}