Explorar o código

fix(Dockerfile): Remove `VOLUME` in Dockerfile

Anonymous volumes are discouraged for reliable persistence.

Users should use named volumes or bind mounts instead. Potentially breaking change, users can also use explicit anonymous volumes instead of relying on implicit anonymous volumes.

`nginx-proxy` really should not be creating implicit anonymous volumes as in most cases it is undesirable.

`git blame` reveals this was added in 2014  by jwilder, with a message that implies implicit anonymous volumes was never intended..
polarathene %!s(int64=3) %!d(string=hai) anos
pai
achega
391ca3e3b5
Modificáronse 2 ficheiros con 0 adicións e 4 borrados
  1. 0 2
      Dockerfile
  2. 0 2
      Dockerfile.alpine

+ 0 - 2
Dockerfile

@@ -70,7 +70,5 @@ WORKDIR /app/
 
 ENV DOCKER_HOST unix:///tmp/docker.sock
 
-VOLUME ["/etc/nginx/certs"]
-
 ENTRYPOINT ["/app/docker-entrypoint.sh"]
 CMD ["forego", "start", "-r"]

+ 0 - 2
Dockerfile.alpine

@@ -67,7 +67,5 @@ WORKDIR /app/
 
 ENV DOCKER_HOST unix:///tmp/docker.sock
 
-VOLUME ["/etc/nginx/certs"]
-
 ENTRYPOINT ["/app/docker-entrypoint.sh"]
 CMD ["forego", "start", "-r"]