All() is fail-fast; no all-errors-at-once aggregation #5

New Issue

2026-09-07T12:22:50Z

claude commented

2026-09-07 12:22:50 +00:00

All(fs...) returns on the first failing validator. That's the right default for a lot of cases, but form and API validation usually wants every problem reported at once ("email is invalid and password is too short"), which is also what ozzo-validation and validator/v10 do.

Today the caller has to run each validator separately and collect the errors themselves.

Sketch of a fix (not implemented — flagged for a decision):

// Collect runs every validator and joins all failures with errors.Join,
// instead of stopping at the first like All. errors.Is still matches any
// individual error in the result.
func Collect[T any](fs ...func(T) error) func(T) error {
    return func(value T) error {
        var errs []error
        for _, f := range fs {
            if err := f(value); err != nil {
                errs = append(errs, err)
            }
        }
        return errors.Join(errs...)
    }
}

Open questions: Collect as a sibling of All, or a variadic option on All? How should the joined error render (newline-joined via errors.Join, or a custom multi-error type with a []error accessor for callers that want to format per-field)? Interaction with #4.

`All(fs...)` returns on the first failing validator. That's the right default for a lot of cases, but form and API validation usually wants *every* problem reported at once ("email is invalid **and** password is too short"), which is also what `ozzo-validation` and `validator/v10` do. Today the caller has to run each validator separately and collect the errors themselves. Sketch of a fix (not implemented — flagged for a decision): ```go // Collect runs every validator and joins all failures with errors.Join, // instead of stopping at the first like All. errors.Is still matches any // individual error in the result. func Collect[T any](fs ...func(T) error) func(T) error { return func(value T) error { var errs []error for _, f := range fs { if err := f(value); err != nil { errs = append(errs, err) } } return errors.Join(errs...) } } ``` Open questions: `Collect` as a sibling of `All`, or a variadic option on `All`? How should the joined error render (newline-joined via `errors.Join`, or a custom multi-error type with a `[]error` accessor for callers that want to format per-field)? Interaction with #4.

claude referenced this issue

2026-09-07 12:23:22 +00:00

Docs: explain what distinguishes validate from other packages #3

claude referenced this issue

2026-09-07 12:23:23 +00:00

No struct-level validation (wire fields by hand) #4

claude referenced this issue from a commit

2026-09-07 12:47:40 +00:00

add Collect: run every validator and join all errors

claude referenced a pull request that will close this issue

2026-09-07 12:47:52 +00:00

add Collect: run every validator and join all errors #10