make tests slightly easier to write

This commit is contained in:
Aneurin Barker Snook
2023-10-07 10:44:47 +01:00
parent fa4f403c46
commit 3c23ea8cde
2 changed files with 17 additions and 17 deletions
+7 -7
View File
@@ -15,18 +15,18 @@ func TestReadParams(t *testing.T) {
},
}
for _, testCase := range testCases {
t.Log("Input:", testCase.Input)
t.Log("Expected output:", testCase.Output)
for _, tc := range testCases {
t.Log("Input:", tc.Input)
t.Log("Expected output:", tc.Output)
params := ReadParams(testCase.Input)
params := ReadParams(tc.Input)
if len(params) != len(testCase.Output) {
t.Errorf("Expected %d parameters", len(testCase.Output))
if len(params) != len(tc.Output) {
t.Errorf("Expected %d parameters", len(tc.Output))
break
}
for i, name := range testCase.Output {
for i, name := range tc.Output {
if params[i] != name {
t.Errorf("Expected parameter %d to be %q", i, name)
}
+10 -10
View File
@@ -27,24 +27,24 @@ RETURN doc`,
},
}
for _, testCase := range testCases {
actualStr := testCase.Input.String()
for _, tc := range testCases {
actualStr := tc.Input.String()
if actualStr != testCase.ExpectedStr {
t.Logf("Expected: %q", testCase.ExpectedStr)
if actualStr != tc.ExpectedStr {
t.Logf("Expected: %q", tc.ExpectedStr)
t.Logf("Actual: %q", actualStr)
t.Fail()
}
if len(testCase.Input.Params) != len(testCase.ExpectedParams) {
t.Errorf("Expected %d parameters; got %d", len(testCase.ExpectedParams), len(testCase.Input.Params))
if len(tc.Input.Params) != len(tc.ExpectedParams) {
t.Errorf("Expected %d parameters; got %d", len(tc.ExpectedParams), len(tc.Input.Params))
}
for name, value := range testCase.ExpectedParams {
if testCase.Input.Params[name] == nil {
for name, value := range tc.ExpectedParams {
if tc.Input.Params[name] == nil {
t.Errorf("Expected parameter %q to be %q; got nil", name, value)
} else if testCase.Input.Params[name] != value {
t.Errorf("Expected parameter %q to be %q; got %q", name, value, testCase.Input.Params[name])
} else if tc.Input.Params[name] != value {
t.Errorf("Expected parameter %q to be %q; got %q", name, value, tc.Input.Params[name])
}
}
}