From 1895ee990aa07d6647337a9ca8cf251cce784f98 Mon Sep 17 00:00:00 2001 From: Aneurin Barker Snook Date: Sat, 25 Nov 2023 16:51:25 +0000 Subject: [PATCH] fix staticcheck suggestions --- params.go | 6 ++---- query.go | 10 +++------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/params.go b/params.go index dc1b05d..b5cdc10 100644 --- a/params.go +++ b/params.go @@ -12,10 +12,8 @@ func ReadParams(input string) []string { params := []string{} matches := paramRegexp.FindAllStringSubmatch(input, -1) - if matches != nil { - for _, match := range matches { - params = append(params, match[1]) - } + for _, match := range matches { + params = append(params, match[1]) } return params diff --git a/query.go b/query.go index 50c8e02..4f5e70a 100644 --- a/query.go +++ b/query.go @@ -57,10 +57,8 @@ func (query *Query) Bind(name string, value any) *Query { // BindMap assigns values to bind parameters. func (query *Query) BindMap(params map[string]any) *Query { - if params != nil { - for name, value := range params { - query.Params[name] = value - } + for name, value := range params { + query.Params[name] = value } return query } @@ -68,9 +66,7 @@ func (query *Query) BindMap(params map[string]any) *Query { // Copy creates a copy of the query. func (query *Query) Copy() *Query { newQuery := NewQuery() - for _, line := range query.Lines { - newQuery.Lines = append(newQuery.Lines, line) - } + newQuery.Lines = append(newQuery.Lines, query.Lines...) for name, value := range query.Params { newQuery.Params[name] = value }