cloud/ultrashorty
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases Activity

Test gaps remaining after the starter suite #4

New Issue
Open
opened 2026-09-07 15:49:28 +00:00 by claude · 1 comment
claude commented 2026-09-07 15:49:28 +00:00
Member
Copy Link
Copy Source

From the review pass on #3. The starter test suite landed there; these are the gaps left for another day.

  • main.go wiring (kong parsing, net.JoinHostPort) is untested. Extracting the body into a testable run() function would make it reachable.
  • CSV parsing edge cases: quoted fields / embedded commas, a UTF-8 BOM, CRLF line endings.
  • ServeHTTP with a non-GET method — it currently redirects regardless of method; decide whether that is wanted for POST and pin it with a test.

Broader (non-test) review notes — query-string handling, path normalisation, main.go panicking on user error, the Redirects.Find linear scan, CI on push, govulncheck pinning, a 0.0.0.0 host default, missing LICENSE — are in the review-notes comment on #3.

From the review pass on #3. The starter test suite landed there; these are the gaps left for another day. - `main.go` wiring (kong parsing, `net.JoinHostPort`) is untested. Extracting the body into a testable `run()` function would make it reachable. - CSV parsing edge cases: quoted fields / embedded commas, a UTF-8 BOM, CRLF line endings. - `ServeHTTP` with a non-GET method — it currently redirects regardless of method; decide whether that is wanted for POST and pin it with a test. Broader (non-test) review notes — query-string handling, path normalisation, `main.go` panicking on user error, the `Redirects.Find` linear scan, CI on push, `govulncheck` pinning, a `0.0.0.0` host default, missing LICENSE — are in the review-notes comment on #3.
aneurin commented 2026-09-07 16:24:23 +00:00
Owner
Copy Link
Copy Source
  • Remove kong and just inline the function body. Make sure to retain support for the command-line options
  • Add CSV tests
  • We only want to redirect GET, HEAD and OPTIONS (I think? Whatever is conventional for a redirection service)

Create separate PRs for each of these.

- Remove kong and just inline the function body. Make sure to retain support for the command-line options - Add CSV tests - We only want to redirect GET, HEAD and OPTIONS (I think? Whatever is conventional for a redirection service) Create separate PRs for each of these.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
aneurin claude (Claude Code) owen (OpenCode)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cloud/ultrashorty#4