Files
project-manager/tests/EmailVerificationTest.php
T
aneurinandClaude Sonnet 5 c82bdbbf0e Passwordless-only auth: drop registration and passwords entirely
There is now one way in: POST /api/auth/magic-link with an email address. It
creates the account (unverified) if the address is new -- that's the only
"sign up" -- and emails a sign-in link either way, subject to the existing
60s-per-user resend throttle. Opening the link (POST /api/auth/verify-email,
unchanged) is what actually creates the session, and marks the address
verified the first time. Since a session can now only ever come from an
opened link, "authenticated" implies "verified" -- there's no more
authenticated-but-unverified state, so the resend-verification endpoint and
all the "verify your email" nagging UI are gone too.

Backend
- migrations/008: ALTER TABLE users DROP COLUMN password_hash.
- UserRepository: create() takes only an email; new findOrCreateByEmail()
  (race-safe) backs the magic-link endpoint.
- AuthController: register()/login() removed; requestLoginLink() now
  find-or-creates before sending.
- EmailVerificationController: resend() removed (dead -- you can't be
  authenticated and unverified); requestChange() drops the password check,
  now just { email }.
- EmailVerifier: sendVerification() removed (unused once register() and
  resend() are gone); sendLoginLink() is the one email people get.
- Routes: POST /auth/register, POST /auth/login, POST /email/verification
  all gone.

Frontend
- LoginView: email field + "Send sign-in link" button, nothing else.
  RegisterView and the /register route are gone.
- auth store: register()/login()/resendVerification() removed;
  requestEmailChange() drops the password param.
- ProfileView: password field and the "verify your email" section removed,
  leaving just the change-email form.
- App.vue: the "verify email" header badge is gone; DashboardView's
  unverified-address notice is gone.
- Now-dead .badge/.badge--warn/a.badge CSS removed.

Tests: AuthTest and EmailVerificationTest rewritten for the new flow (52
tests total, down from 58 -- consolidated, not reduced coverage).
ApiTestCase::authHeader() signs in via the real magic-link -> verify flow.

Verified end-to-end against the rebuilt container and the dev server: a brand
new address gets an account + session from one link; /auth/register,
/auth/login and /email/verification all 404; the UI shows no password field
anywhere and no verification nagging. Also fixed the README's "Try it" curl
snippets, which had been silently broken since JSON_PRETTY_PRINT was added
(grep patterns didn't tolerate the space after ':').

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-04 14:47:46 +01:00

147 lines
6.1 KiB
PHP

<?php
declare(strict_types=1);
namespace Tests;
final class EmailVerificationTest extends ApiTestCase
{
public function test_the_magic_link_email_contains_a_verify_link(): void
{
$this->request('POST', '/api/auth/magic-link', ['email' => 'ada@example.com']);
$email = $this->lastEmail();
self::assertSame('ada@example.com', $email['to']);
self::assertStringContainsString('verify-email?token=', $email['body']);
self::assertStringContainsString('https://app.test/verify-email?token=', $email['body']);
}
public function test_an_invalid_token_is_rejected(): void
{
$response = $this->request('POST', '/api/auth/verify-email', ['token' => 'not-a-real-token']);
self::assertSame(400, $response->getStatusCode());
}
public function test_a_token_cannot_be_used_twice(): void
{
$this->request('POST', '/api/auth/magic-link', ['email' => 'ada@example.com']);
$token = $this->tokenFromEmail();
self::assertSame(200, $this->request('POST', '/api/auth/verify-email', ['token' => $token])->getStatusCode());
$again = $this->request('POST', '/api/auth/verify-email', ['token' => $token]);
self::assertSame(400, $again->getStatusCode());
self::assertStringContainsString('already been used', $this->decode($again)['error']['message']);
}
public function test_an_expired_token_is_rejected(): void
{
$this->request('POST', '/api/auth/magic-link', ['email' => 'ada@example.com']);
$token = $this->tokenFromEmail();
$this->db()->prepare('UPDATE email_verifications SET expires_at = :past WHERE token_hash = :hash')->execute([
'past' => gmdate('Y-m-d\TH:i:s\Z', time() - 60),
'hash' => hash('sha256', $token),
]);
$response = $this->request('POST', '/api/auth/verify-email', ['token' => $token]);
self::assertSame(400, $response->getStatusCode());
self::assertStringContainsString('expired', $this->decode($response)['error']['message']);
}
public function test_a_fresh_link_can_be_requested_once_the_interval_has_passed(): void
{
$this->request('POST', '/api/auth/magic-link', ['email' => 'ada@example.com']);
$this->cooldownElapsed('ada@example.com');
$response = $this->request('POST', '/api/auth/magic-link', ['email' => 'ada@example.com']);
self::assertSame(202, $response->getStatusCode());
self::assertCount(2, $this->sentEmails());
}
public function test_email_change_is_deferred_until_the_new_address_is_confirmed(): void
{
$auth = $this->authHeader('old@example.com');
$this->cooldownElapsed('old@example.com');
$change = $this->request('POST', '/api/email/change', ['email' => 'New@example.com'], $auth);
self::assertSame(202, $change->getStatusCode());
self::assertSame('new@example.com', $this->decode($change)['pending_email']);
self::assertSame('new@example.com', $this->lastEmail()['to']);
// Not applied yet.
$me = $this->decode($this->request('GET', '/api/me', null, $auth));
self::assertSame('old@example.com', $me['user']['email']);
self::assertSame('new@example.com', $me['user']['pending_email']);
// Open the link from the new inbox.
$verified = $this->request('POST', '/api/auth/verify-email', ['token' => $this->tokenFromEmail()]);
self::assertSame(200, $verified->getStatusCode());
$body = $this->decode($verified);
self::assertSame('new@example.com', $body['user']['email']);
self::assertTrue($body['user']['email_verified']);
self::assertNull($body['user']['pending_email']);
}
public function test_email_change_requires_authentication(): void
{
$response = $this->request('POST', '/api/email/change', ['email' => 'new@example.com']);
self::assertSame(401, $response->getStatusCode());
}
public function test_email_change_validates_the_new_address(): void
{
$auth = $this->authHeader('old@example.com');
$this->cooldownElapsed('old@example.com');
$response = $this->request('POST', '/api/email/change', ['email' => 'not-an-email'], $auth);
self::assertSame(422, $response->getStatusCode());
self::assertArrayHasKey('email', $this->decode($response)['error']['details']);
}
public function test_email_change_rejects_an_address_already_in_use(): void
{
$this->authHeader('taken@example.com');
$auth = $this->authHeader('mine@example.com');
$this->cooldownElapsed('mine@example.com');
$response = $this->request('POST', '/api/email/change', ['email' => 'taken@example.com'], $auth);
self::assertSame(409, $response->getStatusCode());
}
public function test_email_change_rejects_the_current_address(): void
{
$auth = $this->authHeader('same@example.com');
$this->cooldownElapsed('same@example.com');
$response = $this->request('POST', '/api/email/change', ['email' => 'same@example.com'], $auth);
self::assertSame(422, $response->getStatusCode());
self::assertArrayHasKey('email', $this->decode($response)['error']['details']);
}
public function test_email_change_is_throttled_immediately_after_signing_in(): void
{
// authHeader() just sent this user a magic link, so the resend window
// (shared with /email/change) hasn't elapsed yet.
$auth = $this->authHeader('throttle@example.com');
$response = $this->request('POST', '/api/email/change', ['email' => 'new@example.com'], $auth);
self::assertSame(429, $response->getStatusCode());
self::assertArrayHasKey('retry_after', $this->decode($response)['error']['details']);
}
/** Push the user's last-sent timestamp far enough back to clear the throttle. */
private function cooldownElapsed(string $email): void
{
$this->db()
->prepare('UPDATE users SET verification_email_sent_at = :ts WHERE email = :email')
->execute(['ts' => gmdate('Y-m-d\TH:i:s\Z', time() - 120), 'email' => $email]);
}
}